CompatHelper: bump compat for DynamicPPL in [weakdeps] to 0.33, (keep existing compat) #309
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
… existing compat)
miguelbiron
force-pushed
the
compathelper/new_version/2025-01-11-01-03-40-839-01336857364
branch
from
d2c2096 to
726b8b5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #309 +/- ##
=======================================
Coverage 87.36% 87.36%
=======================================
Files 107 107
Lines 2644 2644
=======================================
Hits 2310 2310
Misses 334 334 ☔ View full report in Codecov by Sentry. |
|
Seems like julia 1.9 might be too old for bridgestan. The specific problem is that the version of libstdc++ that comes with julia 1.9.4 does not support the stan models compiled with the latest bridgestan; see here See these older issues at the julia repo for related problems:
What's weird is that it doesn't happen across all 1.9 test cases. I'm rerunning everything to triple check. |
|
Another important piece of the puzzle: the "ubuntu-latest" runner is being upgraded to 24.04, but the rollout hasn't fully completed yet. This might explain why only some of the runs encountered libstdc++ mismatches: the ones that failed are the only combinations running ubuntu-latest and julia 1.9. |
|
Should we drop support for 1.9 too? @alexandrebouchard thoughts? |
|
I dont even know what this one is but it definitely is not about DPPL |
|
Can't even see the full logs for some reason, but it fails at the blang test. And I just realized that that specific combination doesn't have a setup-java step. No idea how this test used to pass. Adding it now. |
miguelbiron
deleted the
compathelper/new_version/2025-01-11-01-03-40-839-01336857364
branch
This pull request changes the compat entry for the
DynamicPPLpackage from0.23, 0.24, 0.25, 0.26, 0.27, 0.28, 0.29, 0.30, 0.31, 0.32to0.23, 0.24, 0.25, 0.26, 0.27, 0.28, 0.29, 0.30, 0.31, 0.32, 0.33.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.